Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: read version from VERSION file #2092

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

Vincinator
Copy link
Contributor

@Vincinator Vincinator commented Apr 26, 2024

What this PR does / why we need it:
Currently, a dev build does not retrieve the correct version if it is executed for a rel-* branch.

This PR enables dev actions to run on rel-* branches.

Which issue(s) this PR fixes:
Pushes to a rel- branch will trigger a dev build with the correct version set.

Notes for Reviewer
If this is merged, we will also backport it to rel-1443 branch

@Vincinator Vincinator requested a review from a team as a code owner April 26, 2024 09:19
@Vincinator Vincinator force-pushed the use-version-from-versionfile-in-dev-action branch 3 times, most recently from 4e77df4 to 35fc945 Compare April 26, 2024 10:12
@Vincinator Vincinator marked this pull request as draft April 26, 2024 10:13
@Vincinator Vincinator force-pushed the use-version-from-versionfile-in-dev-action branch from 35fc945 to 1477388 Compare April 26, 2024 12:18
* adds support for dev build action for rel-* branches
@Vincinator Vincinator force-pushed the use-version-from-versionfile-in-dev-action branch 2 times, most recently from 44a8167 to 0adeca5 Compare April 26, 2024 12:33
@Vincinator Vincinator marked this pull request as ready for review April 26, 2024 12:33
Co-authored-by: Florian Wilhelm <2292245+fwilhe@users.noreply.github.com>
@fwilhe fwilhe merged commit 879e70b into main Jun 11, 2024
127 checks passed
@fwilhe fwilhe deleted the use-version-from-versionfile-in-dev-action branch June 11, 2024 07:59
fwilhe pushed a commit that referenced this pull request Jun 11, 2024
Enable `dev` workflow to use the correct version when run on `rel-*` branch by reading version from VERSION file.
@fwilhe
Copy link
Member

fwilhe commented Jun 11, 2024

Cherry-picked to https://github.com/gardenlinux/gardenlinux/tree/rel-1443

@fwilhe
Copy link
Member

fwilhe commented Jun 11, 2024

CI workflow for dev on rel-1443 branch: https://github.com/gardenlinux/gardenlinux/actions/runs/9461786711/job/26063313568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants