Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt GRM networkpolicy and health controller to use controller builder #7416

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Adapt GRM networkpolicy and health controller to use controller builder #7416

merged 2 commits into from
Feb 1, 2023

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Feb 1, 2023 •
edited

How to categorize this PR?

/area control-plane quality
/kind cleanup

What this PR does / why we need it:
This PR adapts the networkpolicy controller in the gardener-resource-manager to use the controller builder like other controllers in #7248.
This was missing in the above PR since this controller was added recently, and I missed to notice it during the rebase.
Also, it was possible to use the controller builder in the health controller as well.
This PR cleans up these issues.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/cc @rfranzke

Release note:

NONE

@gardener-prow gardener-prow bot requested a review from rfranzke February 1, 2023 06:24
@gardener-prow gardener-prow bot added area/control-plane Control plane related area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2023
@gardener-prow gardener-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2023
@shafeeqes shafeeqes changed the title Adapt GRM networkpolicy controller to use controller builder Adapt GRM networkpolicy and health controller to use controller builder Feb 1, 2023
rfranzke
rfranzke reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve
/retest-required

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Feb 1, 2023

LGTM label has been added.

Git tree hash: a9fd4221b16c897667db16d72e100058e154e6e5

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Feb 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Feb 1, 2023 •
edited

@shafeeqes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-e2e-kind-ha-single-zone-upgrade ab223f9 link false /test pull-gardener-e2e-kind-ha-single-zone-upgrade

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gardener-prow gardener-prow bot merged commit 21fa695 into gardener:master Feb 1, 2023
@shafeeqes shafeeqes deleted the enh/networkpolicy branch February 1, 2023 07:28
andrerun pushed a commit to andrerun/gardener that referenced this pull request Jul 6, 2023
@shafeeqes @andrerun
Adapt GRM networkpolicy and health controller to use controller b…
d595d38 
…uilder (gardener#7416)

* Adapt GRM networkpolicy controller

* Adapt GRM `health` controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

Assignees

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Control plane related area/quality Output qualification (tests, checks, scans, automation in general, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shafeeqes @rfranzke