Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build dedicated Schemes in tests #7409

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Build dedicated Schemes in tests #7409

merged 2 commits into from
Feb 1, 2023

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Jan 31, 2023 •
edited

How to categorize this PR?

/area testing
/kind bug

What this PR does / why we need it:
Previously while Adding other clientsets to the scheme, we were mutating the global scheme variable, for eg: GardenScheme, SeedScheme etc.
This PR exposes the AddToScheme functions of GardenScheme,SeedScheme and ShootScheme and builds a dedicated test scheme in the tests.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Depends on #7248, hence in draft.
/cc @timebertt

Release note:

NONE

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jan 31, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/testing Testing related kind/bug Bug cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 31, 2023
@gardener-prow gardener-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 31, 2023
@shafeeqes shafeeqes marked this pull request as ready for review January 31, 2023 12:24
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2023
@shafeeqes
Copy link
Contributor Author

https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/7409/pull-gardener-integration/1620397507202781184 is another occurence of #6904

@shafeeqes
Copy link
Contributor Author

/retest

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Feb 1, 2023

@shafeeqes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-apidiff 2c476de link false /test pull-gardener-apidiff
pull-gardener-e2e-kind-ha-single-zone-upgrade 2c476de link false /test pull-gardener-e2e-kind-ha-single-zone-upgrade

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rfranzke
Copy link
Member

rfranzke commented Feb 1, 2023

/assign

rfranzke
rfranzke reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Feb 1, 2023

LGTM label has been added.

Git tree hash: fac3fe387fd4d645082b86baf4e42aa6bf425d5d

timebertt
timebertt reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, thank you!
/lgtm
/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Feb 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@gardener-prow gardener-prow bot merged commit ca88cb9 into gardener:master Feb 1, 2023
@shafeeqes shafeeqes deleted the test/scheme branch February 1, 2023 11:18
@shafeeqes shafeeqes mentioned this pull request Feb 7, 2023
Merged
andrerun pushed a commit to andrerun/gardener that referenced this pull request Jul 6, 2023
@shafeeqes @andrerun
Build dedicated Schemes in tests (gardener#7409)
32d00c0 
* Expose AddToScheme functions

* Adapt gardenlet controllers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@timebertt timebertt timebertt left review comments

Assignees

@rfranzke rfranzke

@timebertt timebertt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Testing related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shafeeqes @rfranzke @timebertt