Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gardener-kube-scheduler: Support K8s 1.24 Seeds #6173

Merged

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Jun 23, 2022

How to categorize this PR?

/area scalability
/kind enhancement

What this PR does / why we need it:
As there aren't any significant changes in the kube-scheduler config between 1.23 and 1.24, I decided to reuse the 1.23 types for 1.24 as well (instead of duplicating the upstream pkgs for 1.24 under ./third_party).

To check the changes in the kube-scheduler types between 1.23 and 1.24:

git diff release-1.23..release-1.24 ./staging/src/k8s.io/kube-scheduler/config

Which issue(s) this PR fixes:
Part of #4741
Part of #5912

Release note:

`SeedKubeScheduler`: `gardenlet` does now support the `SeedKubeScheduler` feature gate to be enabled for K8s `1.24` Seed clusters.

@gardener-prow gardener-prow bot added area/scalability Scalability related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jun 23, 2022
@gardener-prow gardener-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 23, 2022
@gardener-prow gardener-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 23, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jun 23, 2022

@ialidzhikov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-apidiff 7147c83 link false /test pull-gardener-apidiff

Full PR test history. Your PR dashboard. Command help for this repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 23, 2022
@gardener-prow gardener-prow bot merged commit 3635406 into gardener:master Jun 23, 2022
@ialidzhikov ialidzhikov deleted the enh/seed-kube-scheduler-1.24 branch June 27, 2022 05:58
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/scalability Scalability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants