Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade k8s.io/* to v0.24.1, sigs.k8s.io/controller-runtime to v0.12.1 #6101

Merged
merged 14 commits into from Jun 21, 2022
Merged

Upgrade k8s.io/* to v0.24.1, sigs.k8s.io/controller-runtime to v0.12.1 #6101

merged 14 commits into from Jun 21, 2022

Conversation

krgostev
Copy link
Contributor

@krgostev krgostev commented Jun 13, 2022 •
edited by shafeeqes

How to categorize this PR?

/area open-source
/kind enhancement

What this PR does / why we need it:
This PR upgrades to the latest versions of our go upstream dependencies:

Which issue(s) this PR fixes:
Fixes #5990

Special notes for your reviewer:

Release note:

`k8s.io/*`  is now upgraded to `v0.24.2` and `sigs.k8s.io/controller-runtime` is now upgraded to `v0.12.1`.

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jun 13, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 13, 2022
@krgostev
Copy link
Contributor Author

/test all

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2022
@krgostev
Copy link
Contributor Author

/test pull-gardener-e2e-kind

rfranzke
rfranzke reviewed Jun 14, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
pkg/admissioncontroller/webhooks/admission/auditpolicy/admission.go Outdated Show resolved Hide resolved
pkg/operation/botanist/component/kubecontrollermanager/waiter.go Outdated Show resolved Hide resolved
pkg/utils/kubernetes/leaderelection.go Outdated Show resolved Hide resolved
pkg/utils/kubernetes/leaderelection.go Outdated Show resolved Hide resolved
pkg/utils/kubernetes/leaderelection_test.go Outdated Show resolved Hide resolved
pkg/utils/kubernetes/leaderelection_test.go Outdated Show resolved Hide resolved
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2022
@krgostev
Copy link
Contributor Author

/test all

@rfranzke
Copy link
Member

/assign

@rfranzke rfranzke changed the title Upgrade k8s.io/* to v0.24, sigs.k8s.io/controller-runtime to v0.12.1+ Upgrade k8s.io/* to v0.24.1, sigs.k8s.io/controller-runtime to v0.12.1 Jun 14, 2022
@krgostev krgostev marked this pull request as ready for review June 14, 2022 12:30
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2022
@gardener-prow gardener-prow bot requested a review from plkokanov June 14, 2022 12:30
acumino
acumino reviewed Jun 15, 2022
View reviewed changes
Copy link
Member

@acumino acumino left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments above. controller-tools need to be updated to newer version.

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
pkg/utils/kubernetes/leaderelection.go Show resolved Hide resolved
pkg/utils/kubernetes/leaderelection.go Show resolved Hide resolved
@acumino
Copy link
Member

acumino commented Jun 15, 2022

Apart from the comments above. controller-tools need to be updated to newer version.

controller-tools also need to be updated. Is there any specific reason for not updating it?

acumino
acumino requested changes Jun 15, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@rfranzke rfranzke requested a review from acumino June 15, 2022 14:15
@rfranzke
Copy link
Member

The changes look good to me.
Maybe we can make use of this point from #5990:

We add a Runnable to the manager in provider-local (here).

Also, we generally add Runnables to the manager when registering webhooks to extensions, so this is relevant/interesting for all extensions with webhooks. However, this is not a concern of this PR but rather only when the extensions themselves get revendored.

@rfranzke
Copy link
Member

/needs rebase

@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2022
rfranzke
rfranzke reviewed Jun 21, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
third_party/apiserver/pkg/apis/audit/v1alpha1/conversion_test.go Outdated Show resolved Hide resolved
third_party/apiserver/pkg/apis/audit/v1beta1/conversion_test.go Outdated Show resolved Hide resolved
@rfranzke
Copy link
Member

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jun 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2022
@rfranzke
Copy link
Member

/cla

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jun 21, 2022

Successfully reached out to cla-assistant.io to initialize recheck of PR #6101

@rfranzke
Copy link
Member

/test pull-gardener-e2e-kind

1 similar comment
@rfranzke
Copy link
Member

/test pull-gardener-e2e-kind

@gardener-prow gardener-prow bot merged commit bf9dcf5 into gardener:master Jun 21, 2022
@krgostev krgostev deleted the upgrade-dependencies branch June 21, 2022 15:22
krgostev added a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@krgostev
Upgrade k8s.io/* to v0.24.1, sigs.k8s.io/controller-runtime to …
3bb0709 
…`v0.12.1` (gardener#6101)

* Revendoring to the newest versions

* Remove unsused imports

* Replacing resourcelock constants

* Adding default feature gates to the apiserver loging

* Removing deprecated field

* Upgrading to 0.24.1 plus revendor and generate

* Adapting the unit tests to the new changes

* Changing lock constatns in regard to comments

* Upgrading tools/setup-envtest and client_golang

* Upgrading controller-tools

* Copy audit apis to third_pary to smooth the transition between versions

* Addressing comments for auditpolicy admission

* Fixing comments and e2e test issues

* Updating to 0.24.2
@ialidzhikov ialidzhikov mentioned this pull request Jul 12, 2022
Merged
@acumino acumino mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@ary1992 ary1992 Awaiting requested review from ary1992

@ScheererJ ScheererJ Awaiting requested review from ScheererJ

@plkokanov plkokanov Awaiting requested review from plkokanov

@acumino acumino Awaiting requested review from acumino

Assignees

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade k8s.io/* to v0.24, sigs.k8s.io/controller-runtime to v0.12.1+
3 participants
@krgostev @rfranzke @acumino