Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop usages of k8s.io/apimachinery/pkg/util/clock #6030

Merged
merged 3 commits into from May 27, 2022

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented May 25, 2022

How to categorize this PR?

/area open-source
/kind enhancement

What this PR does / why we need it:
This PR drops usages of "k8s.io/apimachinery/pkg/util/clock" package in favour of "k8s.io/utils/clock".

  • k8s.io/apimachinery/pkg/util/clock.RealClock is replaced with k8s.io/utils/clock.RealClock
  • k8s.io/apimachinery/pkg/util/clock.FakeClock is replaced with k8s.io/utils/clock/testing.FakeClock
  • k8s.io/apimachinery/pkg/util/clock.Clock is replaced with k8s.io/utils/clock.WithTickerAndDelayedExecution

Which issue(s) this PR fixes:
Part of #5990

Special notes for your reviewer:
cc @ary1992

Release note:

NONE

@gardener-prow gardener-prow bot added the area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related label May 25, 2022
@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 25, 2022
@shafeeqes shafeeqes changed the title Deprecate "k8s.io/apimachinery/pkg/util/clock" Drop usages of "k8s.io/apimachinery/pkg/util/clock" May 25, 2022
@rfranzke rfranzke changed the title Drop usages of "k8s.io/apimachinery/pkg/util/clock" Drop usages of k8s.io/apimachinery/pkg/util/clock May 25, 2022
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 27, 2022
@gardener-prow gardener-prow bot merged commit 5da0216 into gardener:master May 27, 2022
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
* Use k8s.io/utils/clock instead of k8s.io/apimachinery/pkg/util/clock

* Use k8s.io/utils/clock/testing instead of k8s.io/apimachinery/pkg/util/clock

* Run `make revendor`
@shafeeqes shafeeqes deleted the deprecate/clock branch July 22, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants