Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Kubernetes v1.24 #6023

Merged
merged 10 commits into from
May 27, 2022
Merged

Support for Kubernetes v1.24 #6023

merged 10 commits into from
May 27, 2022

Conversation

acumino
Copy link
Member

@acumino acumino commented May 24, 2022 •
edited

How to categorize this PR?

/area open-source usability
/kind enhancement

What this PR does / why we need it:
Support for Kubernetes v1.24

Which issue(s) this PR fixes:
Part of #5912

Special notes for your reviewer:

  • ⚠️ This PR only contains the Gardener part for supporting 1.24 - there will/must be follow-up PRs for each extension repository where individual support gets added.
  • Code changes have been tested with the provider-local
    • Create/Delete a new shoot cluster with v1.24.0
    • Upgrade an existing cluster to v1.24.0
    • Register a v1.24.0 as a seed cluster

Release note:

Gardener can now support shoot and seed clusters with Kubernetes version 1.24. In order to allow creation/update of 1.24 clusters you will have to update the version of your provider extension(s) to a version that supports 1.24 as well. Please consult the respective releases and notes in the provider extension's repository.
Gardener can now support seed and shoot clusters with Kubernetes version 1.24. Extension developers have to prepare individual extensions as well to work with 1.24.

@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 24, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related labels May 24, 2022
@gardener-prow gardener-prow bot added area/usability Usability related kind/enhancement Enhancement, improvement, extension size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 24, 2022
@shafeeqes
Copy link
Contributor

/test pull-gardener-unit

@rfranzke
Copy link
Member

/assign

rfranzke
rfranzke reviewed May 24, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update kind version to 1.24 to use 1.24 seed in our e2e tests?

pkg/utils/validation/features/featuregates.go Outdated Show resolved Hide resolved
@rfranzke
Copy link
Member

Please add a proper PR description and release note

@acumino acumino changed the title Kubernetes v1.24 Support for Kubernetes v1.24 May 25, 2022
@rfranzke
Copy link
Member

rfranzke commented May 25, 2022 •
edited

/test all

@vpnachev
Copy link
Member

/uncc

@gardener-prow gardener-prow bot removed the request for review from vpnachev May 25, 2022 06:29
@acumino acumino marked this pull request as ready for review May 26, 2022 05:06
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2022
@vpnachev vpnachev mentioned this pull request May 26, 2022
Merged
@vpnachev
Copy link
Member

/uncc

@gardener-prow gardener-prow bot removed the request for review from vpnachev May 26, 2022 06:41
@acumino
Extend docs to support kubernetes v1.24 and allow client creation
8ed088a
@acumino
Adapt kubernetes feature gates
3de6156 
./hack/compare-k8s-feature-gates.sh 1.23 1.24                                                                                                    ✔
Feature gates added in 1.24 compared to 1.23:
CSIMigrationRBD
CronJobTimeZone
LegacyServiceAccountTokenNoAutoGeneration
MaxUnavailableStatefulSet
MinDomainsInPodTopologySpread
NetworkPolicyStatus
NodeOutOfServiceVolumeDetach
ServiceIPStaticSubrange

Feature gates removed in 1.24 compared to 1.23:
HugePageStorageMediumSize
ImmutableEphemeralVolumes
MigrationRBD
NamespaceDefaultLabelName
RuntimeClass
SetHostnameAsFQDN
StreamingProxyRedirects
ValidateProxyRedirects
WarningHeaders

Feature gates locked to default in 1.24 compared to 1.23:
CSIMigrationOpenStack
CSIStorageCapacity
CSRDuration
ControllerManagerLeaderMigration
DefaultPodTopologySpread
EfficientWatchResumption
IndexedJob
NonPreemptingPriority
PodAffinityNamespaceSelector
PodOverhead
PreferNominatedNode
RemoveSelfLink
ServiceLBNodePortControl
ServiceLoadBalancerClass
SuspendJob
@acumino
Use 1.24 for local shoot
fb70e1f
@acumino
Drop removed flag --insecure-port for v1.24
0a1d195 
ref kubernetes/kubernetes#106859
@rfranzke rfranzke mentioned this pull request May 27, 2022
Closed
12 tasks
@gardener-prow gardener-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 27, 2022
@acumino acumino requested a review from rfranzke May 27, 2022 08:38
rfranzke
rfranzke reviewed May 27, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @acumino! Great work :)

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2022
@gardener-prow
Copy link
Contributor

gardener-prow bot commented May 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2022
@gardener-prow gardener-prow bot merged commit bf03408 into master May 27, 2022
@gardener-prow gardener-prow bot deleted the kubernetes-v1.24 branch May 27, 2022 09:11
@rfranzke rfranzke mentioned this pull request Jun 14, 2022
Merged
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@acumino
Support for Kubernetes v1.24 (gardener#6023)
80491c1 
* Extend docs to support kubernetes v1.24 and allow client creation

* Adapt kubernetes feature gates

./hack/compare-k8s-feature-gates.sh 1.23 1.24                                                                                                    ✔
Feature gates added in 1.24 compared to 1.23:
CSIMigrationRBD
CronJobTimeZone
LegacyServiceAccountTokenNoAutoGeneration
MaxUnavailableStatefulSet
MinDomainsInPodTopologySpread
NetworkPolicyStatus
NodeOutOfServiceVolumeDetach
ServiceIPStaticSubrange

Feature gates removed in 1.24 compared to 1.23:
HugePageStorageMediumSize
ImmutableEphemeralVolumes
MigrationRBD
NamespaceDefaultLabelName
RuntimeClass
SetHostnameAsFQDN
StreamingProxyRedirects
ValidateProxyRedirects
WarningHeaders

Feature gates locked to default in 1.24 compared to 1.23:
CSIMigrationOpenStack
CSIStorageCapacity
CSRDuration
ControllerManagerLeaderMigration
DefaultPodTopologySpread
EfficientWatchResumption
IndexedJob
NonPreemptingPriority
PodAffinityNamespaceSelector
PodOverhead
PreferNominatedNode
RemoveSelfLink
ServiceLBNodePortControl
ServiceLoadBalancerClass
SuspendJob

* Use 1.24 for local shoot

* Drop removed flag --insecure-port for v1.24

ref kubernetes/kubernetes#106859

* Drop removed flag --port for v1.24

ref kubernetes/kubernetes#106860

* Remove deprecated usages of metadata.Selflink

* Use 1.24 e2e test

* Bump kindest/node image to v1.24

* Adapt changes for with k/k v1.24 Secret API objects containing service account tokens are no longer auto-generated for every ServiceAccount

ref kubernetes/kubernetes#108309

* Add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@DockToFuture DockToFuture Awaiting requested review from DockToFuture

@shreyas-s-rao shreyas-s-rao Awaiting requested review from shreyas-s-rao

Assignees

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acumino @shafeeqes @rfranzke @vpnachev