Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Custom Validator of c-r for webhook #5782

Merged
merged 7 commits into from
Apr 25, 2022
Merged

Use Custom Validator of c-r for webhook #5782

merged 7 commits into from
Apr 25, 2022

Conversation

acumino
Copy link
Member

@acumino acumino commented Apr 11, 2022 •
edited

How to categorize this PR?

/area open-source
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of #5282

Special notes for your reviewer:
/cc @timebertt @rfranzke

Release note:

NONE

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Apr 11, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Apr 11, 2022
@gardener-prow gardener-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 11, 2022
@acumino acumino marked this pull request as ready for review April 11, 2022 13:04
@acumino acumino requested a review from a team as a code owner April 11, 2022 13:04
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2022
@acumino acumino requested a review from rfranzke April 12, 2022 06:50
@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2022
@timebertt
Copy link
Member

Sorry for the delay, will have a quick look.
/assign

@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2022
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2022
@acumino acumino requested a review from timebertt April 19, 2022 11:37
@acumino
Copy link
Member Author

acumino commented Apr 19, 2022

/cla

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Apr 19, 2022

Successfully reached out to cla-assistant.io to initialize recheck of PR #5782

@acumino acumino requested a review from timebertt April 25, 2022 06:37
timebertt
timebertt approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Apr 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Apr 25, 2022
@gardener-prow gardener-prow bot merged commit 39ef719 into gardener:master Apr 25, 2022
@acumino acumino mentioned this pull request Apr 25, 2022
Closed
1 task
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@acumino
Use Custom Validator of c-r for webhook (gardener#5782)
87cc326 
* Use Custom Validator of c-r for webhook

* Fix tests

* Address PR Review

* Address PR review and Rebase

* Address PR Review

* Rebase

* Address PR review and Rebase
@acumino acumino deleted the use/c-r-webhook branch November 21, 2022 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@timebertt timebertt timebertt approved these changes

@BeckerMax BeckerMax Awaiting requested review from BeckerMax

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

Assignees

@timebertt timebertt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@acumino @timebertt @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3