Set RecoverPanic to true for controller reconcile
#5383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
area/open-source
|
@acumino Thank you for your contribution. |
gardener-robot
added
the
size/S
|
@rfranzke, @danielfoehrKn You have pull request review open invite, please check |
rfranzke
reviewed
Feb 7, 2022
6 tasks
|
/author-action |
|
@acumino The pull request was assigned to you under |
|
/unassign |
rfranzke
reviewed
Feb 14, 2022
gardener-robot
added
size/XS
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Set Recover panic true for Controllers * Minor Edit * Address PR reviews * Set Recover panic true for extensions Controllers * Address PR Review
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Set Recover panic true for Controllers * Minor Edit * Address PR reviews * Set Recover panic true for extensions Controllers * Address PR Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source
/kind enhancement
What this PR does / why we need it:
This PR sets the
RecoverPanicto true for the controller reconcile. Now any panics raised by the reconciler are converted to normal errors.Which issue(s) this PR fixes:
Part of #4772
Release note: