Add ready check for Webhook server #5380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/open-source
|
@acumino Thank you for your contribution. |
gardener-robot
added
needs/review
size/S
rfranzke
reviewed
Feb 4, 2022
There was a problem hiding this comment.
/invite @timebertt
@acumino Should we now also define the readinessProbes in the respecitve Deployment specs?
6 tasks
timebertt
requested changes
Feb 9, 2022
cmd/gardener-admission-controller/app/gardener_admission_controller.go
Outdated
Show resolved
Hide resolved
acumino
force-pushed
the
ehc/webhook-healthcheck
branch
from
b895f20
to
b63885c
Compare
gardener-robot
added
size/M
acumino
force-pushed
the
ehc/webhook-healthcheck
branch
from
b63885c
to
d6fa37d
Compare
rfranzke
reviewed
Feb 15, 2022
|
@acumino Can you check why the e2e test is failing? |
acumino
force-pushed
the
ehc/webhook-healthcheck
branch
from
6855fcf
to
6855a3d
Compare
timebertt
reviewed
Feb 24, 2022
charts/gardener/provider-local/extension/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
charts/gardener/provider-local/extension/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
|
/author-action |
|
@acumino The pull request was assigned to you under |
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Add ready check for webhook server * Delete not required files * Add readinessProbe * Add flag for health bind Address * Add livenessprobe * Rebase * Move HealthBindAddress to extesnions * Address PR Review
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Add ready check for webhook server * Delete not required files * Add readinessProbe * Add flag for health bind Address * Add livenessprobe * Rebase * Move HealthBindAddress to extesnions * Address PR Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source
/kind enhancement
What this PR does / why we need it:
The PR adds ready check for webhook server. The ready check wait for
10 secfor webhook server to be ready, otherwise throws error.Which issue(s) this PR fixes:
Part of #4772
Special notes for your reviewer:
Since
StartedChecker()is part of Kubernetes. I don't see any need to keep an extra function that just wraps around it.Release note: