Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump envtest binaries to v1.22 #4851

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:

Bump envtest binaries to v1.22 to make use of disabled etcd fsync in envtests.

Quick comparison on my machine:
Before:

$ make test-integration
> Installing envtest tools@1.20 with setup-envtest if necessary
using envtest tools installed at '/Users/timebertt/Library/Application Support/io.kubebuilder.envtest/k8s/1.20.2-darwin-amd64'
> Integration Tests
ok  	github.com/gardener/gardener/extensions/test/integration/envtest/backupbucket	47.720s
ok  	github.com/gardener/gardener/test/integration/envtest/envtest	30.591s
ok  	github.com/gardener/gardener/test/integration/envtest/seedadmissioncontroller	33.503s
ok  	github.com/gardener/gardener/test/integration/envtest/shootretry	32.240s

After:

$ make test-integration
> Installing envtest tools@1.22 with setup-envtest if necessary
using envtest tools installed at '/Users/d067603/Library/Application Support/io.kubebuilder.envtest/k8s/1.22.0-darwin-amd64'
> Integration Tests
ok  	github.com/gardener/gardener/extensions/test/integration/envtest/backupbucket	31.206s
ok  	github.com/gardener/gardener/test/integration/envtest/envtest	14.243s
ok  	github.com/gardener/gardener/test/integration/envtest/seedadmissioncontroller	13.674s
ok  	github.com/gardener/gardener/test/integration/envtest/shootretry	14.426s

Which issue(s) this PR fixes:
Part of #4772

Special notes for your reviewer:

This is a breaking change for extensions, as they need to update the CRDs that are added during integration tests.
E.g. this test will start failing: https://github.com/gardener/gardener-extension-provider-aws/blob/51d2a020b218c16d4dbc1f0a197c9a83bae9f48e/test/integration/dnsrecord/dnsrecord_test.go#L110-L122
Ref gardener/gardener-extension-provider-aws#430

Release note:

Envtest binaries have been upgraded to version v1.22. By this, we disable etcd fsync in envtests which speeds up test execution by not writing etcd data to disk.
Envtest binaries have been upgraded to version v1.22. Please ensure to update your CRD and Webhook manifests to API versions supported in v1.22. You can consult [this guide](https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-22) for help on the migration.

@timebertt timebertt requested a review from a team as a code owner October 15, 2021 06:55
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension needs/review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 15, 2021
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 5189e88 into gardener:master Oct 15, 2021
@timebertt timebertt deleted the upgrade/envtest-binaries branch October 15, 2021 14:05
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants