Remove creation of static node bootstrapToken #4824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
size/M
|
/assign |
rfranzke
requested changes
Oct 14, 2021
|
/merge squash |
|
Thank you very much for the review. I applied your suggestions. |
|
/rebase |
This commit is part of issue [gardener#3898](gardener#3898) which replaces the long-valid bootstrap-token shared between nodes with a short-lived token unique for each node. The new flow of using smaller-scoped, short-lived tokens was already active once you updated to compatible versions of the infrastructure-extension, operatingsystem-extension and of gardener/gardener as specified in: gardener#3898 With this commit we are now removing the old secret from the Shoot which means you need to run supported versions of the os-extensions and the infrastructure-provider-extensions when upgrading gardener to this version.
Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>
BeckerMax
force-pushed
the
cleanup/node-bootstrap-token
branch
from
032ee50
to
5def4de
Compare
rfranzke
reviewed
Oct 18, 2021
Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>
rfranzke
approved these changes
Oct 20, 2021
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Remove creation of static node bootstrapToken This commit is part of issue [gardener#3898](gardener#3898) which replaces the long-valid bootstrap-token shared between nodes with a short-lived token unique for each node. The new flow of using smaller-scoped, short-lived tokens was already active once you updated to compatible versions of the infrastructure-extension, operatingsystem-extension and of gardener/gardener as specified in: gardener#3898 With this commit we are now removing the old secret from the Shoot which means you need to run supported versions of the os-extensions and the infrastructure-provider-extensions when upgrading gardener to this version. * Apply suggestions from rfranzke Co-authored-by: Rafael Franzke <rafael.franzke@sap.com> * Change shipped feature to v1.35 Co-authored-by: Rafael Franzke <rafael.franzke@sap.com> Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Remove creation of static node bootstrapToken This commit is part of issue [gardener#3898](gardener#3898) which replaces the long-valid bootstrap-token shared between nodes with a short-lived token unique for each node. The new flow of using smaller-scoped, short-lived tokens was already active once you updated to compatible versions of the infrastructure-extension, operatingsystem-extension and of gardener/gardener as specified in: gardener#3898 With this commit we are now removing the old secret from the Shoot which means you need to run supported versions of the os-extensions and the infrastructure-provider-extensions when upgrading gardener to this version. * Apply suggestions from rfranzke Co-authored-by: Rafael Franzke <rafael.franzke@sap.com> * Change shipped feature to v1.35 Co-authored-by: Rafael Franzke <rafael.franzke@sap.com> Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area security
/kind cleanup
What this PR does / why we need it:
This commit is part of issue #3898
which replaces the long-valid bootstrap-token shared between nodes with a
short-lived token unique for each node.
The new flow of using smaller-scoped, short-lived tokens was already active
once you updated to compatible versions of the infrastructure-extension,
operatingsystem-extension and of gardener/gardener.
With this commit we are now removing the old secret from the Shoot
which means you need to run supported versions of the os-extensions
and the infrastructure-provider-extensions when
upgrading gardener to this version.
A compatibility matrix is added to the documentation which includes the required versions needed.
Which issue(s) this PR fixes:
Fixes #3898
Release note: