Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix promtool installation #3558

Merged
merged 1 commit into from Feb 12, 2021
Merged

Fix promtool installation #3558

merged 1 commit into from Feb 12, 2021

Conversation

ialidzhikov
Copy link
Member

/kind bug

Because of prometheus/client_golang#828 the installation of promtool with go get (for unknown reasons 馃槥 ) fails with:

# github.com/prometheus/prometheus/cmd/promtool
../../prometheus/prometheus/cmd/promtool/main.go:645:35: not enough arguments in call to api.LabelValues
	have (context.Context, string, time.Time, time.Time)
	want (context.Context, string, []string, time.Time, time.Time)
make: *** [Makefile:139: install-requirements] Error 2

Ref https://concourse.ci.gardener.cloud/teams/gardener/pipelines/gardener-master/jobs/master-pull-request-job/builds/705

Many thanks to @vpnachev 鉂わ笍

Release note:

NONE

@ialidzhikov ialidzhikov requested a review from a team as a code owner February 12, 2021 14:41
@gardener-robot gardener-robot added kind/bug Bug needs/review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2021
rfranzke
rfranzke previously approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ialidzhikov and @vpnachev for your fast reaction!
/lgtm

@ialidzhikov @vpnachev
Fix promtool installation
37013c5 
Co-authored-by: vpnachev <vladimir.nachev@sap.com>
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
vpnachev
vpnachev approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vpnachev
Copy link
Member

By the way, this seems to reduce the execution time for verify with 4-5 minutes. go get was downloading some 2GiB, so this is now reduced to around 60MiB.

@rfranzke
Copy link
Member

Crazy. Thanks again!

@rfranzke rfranzke merged commit 6a6b77f into gardener:master Feb 12, 2021
@ialidzhikov ialidzhikov deleted the fix/promtool-installation branch February 12, 2021 18:54
@ialidzhikov ialidzhikov mentioned this pull request Feb 15, 2021
Merged
ezeeyahoo pushed a commit to ezeeyahoo/gardener that referenced this pull request Feb 17, 2021
@ialidzhikov @vpnachev @ezeeyahoo
Fix promtool installation (gardener#3558)
bf4123c 
Co-authored-by: vpnachev <vladimir.nachev@sap.com>
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>

Co-authored-by: vpnachev <vladimir.nachev@sap.com>
@ialidzhikov ialidzhikov mentioned this pull request Feb 19, 2021
Merged
krgostev pushed a commit to krgostev/gardener that referenced this pull request Apr 21, 2022
@ialidzhikov @vpnachev
Fix promtool installation (gardener#3558)
48681c2 
Co-authored-by: vpnachev <vladimir.nachev@sap.com>
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>

Co-authored-by: vpnachev <vladimir.nachev@sap.com>
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
@ialidzhikov @vpnachev
Fix promtool installation (gardener#3558)
5d03bdb 
Co-authored-by: vpnachev <vladimir.nachev@sap.com>
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>

Co-authored-by: vpnachev <vladimir.nachev@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
kind/bug Bug size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ialidzhikov @vpnachev @rfranzke @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot