Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ResourceQuota for projects #3072

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Add ResourceQuota for projects #3072

merged 1 commit into from
Nov 4, 2020

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented Oct 30, 2020 •
edited

How to categorize this PR?

/area security
/area robustness
/kind enhancement
/priority normal

What this PR does / why we need it:
This PR enhances the Project controller by the option to maintain a default ResourceQuota for projects. If specified, GCM creates or updates a ResourceQuota named gardener in the project namespace.

Which issue(s) this PR fixes:
Fixes #1650

Release note:

Operators can now define a default `ResourceQuota` resource which is automatically created in project related namespaces. Please consult the documentation (/docs/concepts/controller-manager.md) for more information.

@timuthy timuthy requested a review from a team as a code owner October 30, 2020 11:41
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion area/robustness Robustness, reliability, resilience related area/security Security related kind/enhancement Enhancement, improvement, extension size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 30, 2020
rfranzke
rfranzke reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, one small question :)

pkg/controllermanager/apis/config/validation/validation.go Outdated Show resolved Hide resolved
@rfranzke rfranzke self-assigned this Nov 2, 2020
timebertt
timebertt requested changes Nov 2, 2020
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, looks good. Just a few suggestions :)

docs/concepts/controller-manager.md Outdated Show resolved Hide resolved
example/20-componentconfig-gardener-controller-manager.yaml Outdated Show resolved Hide resolved
pkg/controllermanager/apis/config/types.go Outdated Show resolved Hide resolved
pkg/controllermanager/apis/config/types.go Outdated Show resolved Hide resolved
@timuthy
Copy link
Contributor Author

timuthy commented Nov 3, 2020

Thanks for your comments @rfranzke and @timebertt. The PR is ready for another round of reviews. I especially added support for multiple quota configs in 3781169.

rfranzke
rfranzke previously approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

timebertt
timebertt reviewed Nov 4, 2020
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, Tim! Thanks for addressing my suggestions.
Only a few minor comments left :)

docs/concepts/controller-manager.md Outdated Show resolved Hide resolved
pkg/controllermanager/apis/config/types.go Outdated Show resolved Hide resolved
pkg/controllermanager/controller/project/project_control_reconcile.go Outdated Show resolved Hide resolved
timebertt
timebertt approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments again, looks great now!
/lgtm

@rfranzke rfranzke merged commit 9626e57 into gardener:master Nov 4, 2020
@timuthy timuthy deleted the feature.project-quota branch November 4, 2020 15:45
@petersutter petersutter mentioned this pull request Nov 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@timebertt timebertt timebertt approved these changes

Assignees

@rfranzke rfranzke

@timuthy timuthy

Labels
area/robustness Robustness, reliability, resilience related area/security Security related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quota for user facing resources
7 participants
@timuthy @rfranzke @timebertt @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot