Add resource size validator #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/security
rfranzke
requested changes
Aug 28, 2020
pkg/controllermanager/apis/config/validation/ControllerManagerConfiguration.go
Outdated
Show resolved
Hide resolved
pkg/controllermanager/server/handlers/webhooks/validate_resource_size.go
Outdated
Show resolved
Hide resolved
pkg/controllermanager/server/handlers/webhooks/validate_resource_size.go
Outdated
Show resolved
Hide resolved
ialidzhikov
reviewed
Aug 31, 2020
...gardener/controlplane/charts/application/templates/validatingwebhook-controller-manager.yaml
Outdated
Show resolved
Hide resolved
...gardener/controlplane/charts/application/templates/validatingwebhook-controller-manager.yaml
Outdated
Show resolved
Hide resolved
pkg/controllermanager/apis/config/validation/ControllerManagerConfiguration.go
Outdated
Show resolved
Hide resolved
timuthy
force-pushed
the
feature.size-validator
branch
from
dfc325b
to
579fa5c
Compare
|
Thanks for your rewiews @rfranzke @ialidzhikov. I already addressed your comments but as discussed in our internal meeting, I'll continue to move out the webhooks to a dedicated component so that we have:
|
timuthy
force-pushed
the
feature.size-validator
branch
from
579fa5c
to
a98e6ee
Compare
|
Please update the PR now that #2832 is merged :) |
rfranzke
requested changes
Sep 14, 2020
pkg/admissioncontroller/apis/config/validation/controllerManagerConfiguration.go
Outdated
Show resolved
Hide resolved
pkg/admissioncontroller/apis/config/validation/controllerManagerConfiguration_test.go
Outdated
Show resolved
Hide resolved
pkg/admissioncontroller/apis/config/validation/controllerManagerConfiguration_test.go
Outdated
Show resolved
Hide resolved
pkg/admissioncontroller/apis/config/validation/validation_suite_test.go
Outdated
Show resolved
Hide resolved
pkg/admissioncontroller/server/handlers/webhooks/webhooks_suite_test.go
Outdated
Show resolved
Hide resolved
timuthy
force-pushed
the
feature.size-validator
branch
from
a98e6ee
to
87272f1
Compare
|
/unhold |
rfranzke
requested changes
Sep 15, 2020
pkg/admissioncontroller/apis/config/validation/admissionControllerConfiguration.go
Outdated
Show resolved
Hide resolved
pkg/admissioncontroller/apis/config/validation/admissionControllerConfiguration_test.go
Outdated
Show resolved
Hide resolved
timuthy
force-pushed
the
feature.size-validator
branch
from
cfc47a7
to
a616688
Compare
timuthy
force-pushed
the
feature.size-validator
branch
from
a616688
to
42709f9
Compare
|
Thanks @rfranzke, I force pushed again to squash the commits. |
ialidzhikov
reviewed
Sep 15, 2020
pkg/admissioncontroller/server/handlers/webhooks/validate_resource_size.go
Show resolved
Hide resolved
|
Thanks @ialidzhikov for the feedback. PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area security
/kind enhancement
/priority normal
What this PR does / why we need it:
This PR adds the Resource Size Validator which is a webook for GCM and can be used to restrict the size of resources applied by end users. Please consult the enclosed documentation
docs/concepts/controller-manager.mdfor more details.Which issue(s) this PR fixes:
Fixes parts of #1650
Release note: