Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ready check for webhook server #473

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Add ready check for webhook server #473

merged 2 commits into from
Apr 11, 2022

Conversation

acumino
Copy link
Member

@acumino acumino commented Apr 4, 2022

How to categorize this PR?

/area open-source
/kind enhancement
/platform azure

What this PR does / why we need it:
The PR adds ready check for webhook server. The ready check wait for 10 sec for webhook server to be ready, otherwise throws error.

Which issue(s) this PR fixes:
Part of gardener/gardener#4772

Special notes for your reviewer:

Release note:

NONE

@acumino acumino requested review from a team as code owners April 4, 2022 04:53
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 4, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 4, 2022
@acumino acumino added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure labels Apr 4, 2022
@gardener-robot gardener-robot added the needs/review Needs review label Apr 4, 2022
@acumino
Copy link
Member Author

acumino commented Apr 4, 2022

/retest

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 4, 2022
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Apr 4, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 7, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 7, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 7, 2022
@acumino
Copy link
Member Author

acumino commented Apr 7, 2022 •
edited

/invite @kon-angelo

@gardener-robot
Copy link

@kon-angelo You have pull request review open invite, please check

dkistner
dkistner approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 11, 2022
ary1992
ary1992 reviewed Apr 11, 2022
View reviewed changes
Copy link
Contributor

@ary1992 ary1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits.

cmd/gardener-extension-admission-azure/app/app.go Show resolved Hide resolved
cmd/gardener-extension-admission-azure/app/app.go Show resolved Hide resolved
cmd/gardener-extension-provider-azure/app/app.go Show resolved Hide resolved
@acumino
Copy link
Member Author

acumino commented Apr 11, 2022

/invite @kon-angelo

@dkistner dkistner merged commit bc19e3b into gardener:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ary1992 ary1992 ary1992 left review comments

@dkistner dkistner dkistner approved these changes

@kon-angelo kon-angelo Awaiting requested review from kon-angelo

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@acumino @gardener-robot @dkistner @ary1992 @gardener-robot-ci-2 @gardener-robot-ci-3