Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ready check for webhook server #465

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Add ready check for webhook server #465

merged 2 commits into from
Apr 11, 2022

Conversation

acumino
Copy link
Member

@acumino acumino commented Apr 7, 2022

How to categorize this PR?

/area open-source
/kind enhancement
/platform alicloud

What this PR does / why we need it:
The PR adds ready check for webhook server. The ready check wait for 10 sec for webhook server to be ready, otherwise throws error.

Which issue(s) this PR fixes:
Part of gardener/gardener#4772

Special notes for your reviewer:

Release note:

NONE

@acumino acumino requested review from a team as code owners April 7, 2022 05:25
@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension platform/alicloud Alicloud platform/infrastructure labels Apr 7, 2022
@gardener-robot
Copy link

@acumino Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Apr 7, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 7, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 7, 2022
@acumino
Copy link
Member Author

acumino commented Apr 7, 2022 •
edited

/invite @kon-angelo @jia-jerry

@shaoyongfeng
Copy link
Contributor

what will happen if webhook server is not ready yet but user creates shoot at this time?

@acumino
Copy link
Member Author

acumino commented Apr 7, 2022

what will happen if webhook server is not ready yet but user creates shoot at this time?

It doesn't send the request to webhook until it's not ready.

@shaoyongfeng
Copy link
Contributor

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 8, 2022
@shaoyongfeng shaoyongfeng merged commit 2aa5484 into gardener:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaoyongfeng shaoyongfeng shaoyongfeng approved these changes

@jia-jerry jia-jerry Awaiting requested review from jia-jerry

@kon-angelo kon-angelo Awaiting requested review from kon-angelo

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/alicloud Alicloud platform/infrastructure reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@acumino @gardener-robot @shaoyongfeng @gardener-robot-ci-2 @gardener-robot-ci-3