Skip to content

Commit

Permalink
Consider control-plane flag (#159)
Browse files Browse the repository at this point in the history
  • Loading branch information
petersutter committed May 17, 2022
1 parent e569144 commit 92aca48
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/target/target_flags.go
Expand Up @@ -87,7 +87,7 @@ func (tf *targetFlagsImpl) AddFlags(flags *pflag.FlagSet) {
}

func (tf *targetFlagsImpl) ToTarget() Target {
return NewTarget(tf.gardenName, tf.projectName, tf.seedName, tf.shootName)
return NewTarget(tf.gardenName, tf.projectName, tf.seedName, tf.shootName).WithControlPlane(tf.controlPlane)
}

func (tf *targetFlagsImpl) isEmpty() bool {
Expand Down
9 changes: 9 additions & 0 deletions pkg/target/target_flags_test.go
Expand Up @@ -77,6 +77,15 @@ var _ = Describe("Target Flags", func() {
Expect(t.ControlPlane()).To(BeTrue())
})

It("should convert to target", func() {
t := target.NewTargetFlags("garden", "project", "", "shoot", true).ToTarget()
Expect(t.GardenName()).To(Equal("garden"))
Expect(t.ProjectName()).To(Equal("project"))
Expect(t.SeedName()).To(BeEmpty())
Expect(t.ShootName()).To(Equal("shoot"))
Expect(t.ControlPlane()).To(BeTrue())
})

It("should fail to override a target", func() {
tf := target.NewTargetFlags("", "", "", "shoot", false)
_, err := tf.OverrideTarget(target.NewTarget("", "b", "c", "d"))
Expand Down

0 comments on commit 92aca48

Please sign in to comment.