Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CustomReporter from envtest #493

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Remove CustomReporter from envtest #493

merged 1 commit into from
Dec 22, 2022

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Dec 22, 2022 •
edited

How to categorize this PR?

/area open-source
/kind cleanup

What this PR does / why we need it:
This PR removes the dependency of sigs.k8s.io/controller-runtime/pkg/envtest/printer package in etcd-druid.
This is anyway removed in ginkgo/v2, ref: 3ccad50, but that PR is currently on hold due to #450 (comment).

There is a dependency cycle between gardener/gardener and etcd-druid since etcd-druid imports g/g and g/g imports etcd-druid for API types.
Currently upgrading to controller-runtime v0.14.1 in gardener is blocked because etcd-druid imports this package which is removed in the controller-runtime. ref: gardener/gardener#7248

Special notes for your reviewer:

Release note:

The dependency of `sigs.k8s.io/controller-runtime/pkg/envtest/printer` package in `etcd-druid` is removed.

@shafeeqes shafeeqes requested a review from a team as a code owner December 22, 2022 04:58
@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 22, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 22, 2022
@aaronfern
Copy link
Contributor

/assign

aaronfern
aaronfern approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 22, 2022
@aaronfern aaronfern merged commit c7ee149 into gardener:master Dec 22, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 22, 2022
@shafeeqes shafeeqes deleted the fix/cr branch December 22, 2022 09:37
@shafeeqes
Copy link
Contributor Author

Thanks! @aaronfern

@shafeeqes shafeeqes mentioned this pull request Dec 22, 2022
Merged
@shafeeqes shafeeqes mentioned this pull request Jan 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfern aaronfern aaronfern approved these changes

Assignees

@aaronfern aaronfern

Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shafeeqes @aaronfern @gardener-robot-ci-1 @gardener-robot