Fix AttributeError When Running in Windows with No Console #256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216.
Running PyInstaller with the option to enable verbose imports was causing an AttributeError, because PyInstaller couldn't write to sys.stderr because it was set to None due to having no console. Although this change is pretty straightforward, it required changes to the PyInstaller bootloader which is written in C to get the Python traceback information to debug the issue.
This also fixes an issue introduced with #236 to add the
locale
directory as data when packaging the app.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The packaged version of Gaphor launches in Windows with a console visible.
Issue Number: #216
What is the new behavior?
The console is removed.
Does this PR introduce a breaking change?
Other information