Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeError When Running in Windows with No Console #256

Merged
merged 3 commits into from
Jan 7, 2020

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Dec 28, 2019

Fixes #216.

Running PyInstaller with the option to enable verbose imports was causing an AttributeError, because PyInstaller couldn't write to sys.stderr because it was set to None due to having no console. Although this change is pretty straightforward, it required changes to the PyInstaller bootloader which is written in C to get the Python traceback information to debug the issue.

This also fixes an issue introduced with #236 to add the locale directory as data when packaging the app.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

The packaged version of Gaphor launches in Windows with a console visible.

Issue Number: #216

What is the new behavior?

The console is removed.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Signed-off-by: Dan Yeaw <dyeaw@ford.com>
Signed-off-by: Dan Yeaw <dyeaw@ford.com>
Signed-off-by: Dan Yeaw <dyeaw@ford.com>
@danyeaw danyeaw merged commit 9cd6a70 into master Jan 7, 2020
@danyeaw danyeaw deleted the fix-no-console branch January 7, 2020 01:00
@danyeaw danyeaw added the bug An issue in the application label Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue in the application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Package Shows the Console while Running
1 participant