Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Ktlint to 1.1.1 #580

Merged
merged 4 commits into from
Mar 3, 2024
Merged

Bump Ktlint to 1.1.1 #580

merged 4 commits into from
Mar 3, 2024

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Oct 21, 2023

@Goooler
Copy link
Contributor Author

Goooler commented Oct 21, 2023

Not sure why this update hasen't been sent by @dependabot automatically, maybe we can use @renovate-bot to replace it.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.66%. Comparing base (8765035) to head (66d81ca).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #580      +/-   ##
============================================
- Coverage     88.16%   86.66%   -1.50%     
  Complexity       91       91              
============================================
  Files            17       17              
  Lines           625      555      -70     
  Branches         59       59              
============================================
- Hits            551      481      -70     
  Misses           35       35              
  Partials         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Goooler Goooler changed the title Bump Ktlint to 1.0.1 Bump Ktlint to 1.1.0 Dec 23, 2023
@Goooler Goooler changed the title Bump Ktlint to 1.1.0 Bump Ktlint to 1.1.1 Feb 2, 2024
@nilsschmidthamburg
Copy link

The commit itself looks good.
It seems the pipeline failed because some service was temporarly not available.
@see "curl: (22) The requested URL returned error: 503 Service Temporarily Unavailable"

Could somebody with matching rights retrigger the job to see if it will run through now.

We would be very happy to see a version of ktlint-maven-plugin supporting kltint 1.1.1 in the near future.
Thanks for the great work!

@sanyarnd
Copy link

@gantsign any chance to update the plugin?

It doesn't detect inlined string constants as dependency use.
@freemanjp freemanjp merged commit 90c7da9 into gantsign:main Mar 3, 2024
7 of 8 checks passed
@Goooler Goooler deleted the ktlint-101 branch March 3, 2024 15:59
@freemanjp
Copy link
Member

@Goooler thanks for the PR, sorry for the delay. You can find your fix in version 3.1.1 of this plugin (it may take a few hours for it to be downloadable from Maven Central),

@Goooler
Copy link
Contributor Author

Goooler commented Mar 3, 2024

It would be better to follow the latest ktlint version 1.2.1, and draft a new release.

@Goooler
Copy link
Contributor Author

Goooler commented Mar 3, 2024

Not sure why @dependabot hasn't sent ktlint updates, maybe we can replace it with @renovate-bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants