Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remind Java 16 users to add extra JVM arg #544

Closed
wants to merge 1 commit into from

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Mar 25, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bd24382) 87.98% compared to head (9f7679b) 87.98%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #544   +/-   ##
=========================================
  Coverage     87.98%   87.98%           
  Complexity       84       84           
=========================================
  Files            16       16           
  Lines           566      566           
  Branches         62       62           
=========================================
  Hits            498      498           
  Misses           25       25           
  Partials         43       43           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@freemanjp
Copy link
Member

@Goooler thanks for your PR. I gave this quite a bit of thought when I added the comment relating to strong encapsulation. Java 16 had been out of support for nearly a year when the comment was added (which I think says something about the number of users of non-LTS Java releases), and it's been out of support for nearly a year and a half now. While you're right that Java 16 is the first affected version, I expect very few projects will be adding this plugin to a Java 16 project at this point (or upgrading a pre-16 project to Java 16). I figured more people would be served by explicitly naming the 17 LTS release than by saying 16 and higher.
If you feel strongly that 16 should be mentioned, we can compromise by mentioning it in the description (in addition the Java 17) and by leaving the heading the same.

@Goooler
Copy link
Contributor Author

Goooler commented Mar 25, 2023

Either way, I was guessing this is intended, thanks for your explanation.

@Goooler Goooler closed this Mar 25, 2023
@Goooler Goooler deleted the arg branch March 25, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants