Add an Invocations Panel for the Invocations activity #18137
Conversation
i.e.: Do not render the `<- Invocations List` button if you open the invocation state overview from the invocations panel
Maybe we should consolidate styling for all scroll lists
ahmedhamidawan
force-pushed
the
invocations_panel
branch
from
7646dcd
to
dbb91c8
Compare
|
This is a step backwards in usability, can we revert that for the time being ? |
|
I guess it'd have been nice to have a little bit of time to review this, but maybe it is worth getting this in front of users. Could we get the full invocation list button at the top of the panel, and is it possible to keep the invocation activity we have on 24.0 as an option that people like me could continue to use ? |
|
@mvdbeek We talked about this at the UI/UX meeting last week, it's not like this was rushed in -- at the time you mentioned you were concerned about the amount of real estate each invocation has in the panel, but that it'd be good to get in front of more people for more opinions. I agree. |
|
|
(to be fair the 1 hour is likely more than that, with rounding) |
|
Thank you for the screenshot. This PR has been open over a week, and the timestamps you're showing there are showing the simple rebase on top of the parent. I don't know what point you are making. |
|
That it was a draft until an hour ago. There's so much going on that I don't have time to review every draft, but given I had expressed concerns earlier it would have been nice (but not a must) to have some time to review this. It's my fault of course, I could've requested changes earlier on. |
|
Sure, a draft so we could discuss it like we did during the call last week, and in draft waiting on the parent PR to be merged so it could be rebased. Again, this was not rushed, there's been a week post-discussion. |
Requires #18088
invocations_activity_panel_third.mp4
How to test the changes?
(Select all options that apply)
License