Add galaxy to user agent #18003
Merged
Add galaxy to user agent #18003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/testing
area/API
area/jobs
area/workflows
area/database
|
Very cool typing stuff in there! I'll have to revisit that and dig in more - looks great. |
nsoranzo
reviewed
May 20, 2024
| @@ -26,6 +26,7 @@ | |||
| stream_to_file, | |||
| stream_url_to_file, | |||
| ) | |||
| from galaxy.util import user_agent # noqa: F401 | |||
There was a problem hiding this comment.
This is not needed any more as well, I think?
| @@ -133,6 +133,7 @@ | |||
| build_tours_registry, | |||
| ToursRegistry, | |||
| ) | |||
| from galaxy.util import user_agent # noqa: F401 | |||
There was a problem hiding this comment.
This is not needed any more, right?
| @@ -4,7 +4,7 @@ | |||
| import os | |||
| import urllib.parse | |||
|
|
|||
| import requests | |||
| from galaxy.util import requests | |||
There was a problem hiding this comment.
Should be moved after the gitlab import try/except.
| import yaml | ||
|
|
||
| from galaxy.util import requests |
There was a problem hiding this comment.
This doesn't make much sense for this and the other scripts in scripts/api/ as they are meant to be example for how to connect to a Galaxy instance (not from a Galaxy server).
| @@ -1,4 +1,4 @@ | |||
| import requests | |||
| from galaxy.util import requests | |||
There was a problem hiding this comment.
This one was also not needed, I think.
| @@ -68,6 +67,8 @@ | |||
| Self, | |||
| ) | |||
|
|
|||
| from galaxy.util import requests | |||
There was a problem hiding this comment.
Should be moved after the try/except imports (and can be rewritten as from . import requests).
|
Yes, that'd be great, thank you @nsoranzo! |
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
May 22, 2024
introduced in galaxyproject#18003 . In particular, when using requests in the tests to connect to Galaxy or the ToolShed it's not needed to use the modified headers. Also: - Move some imports after conditional imports. - Fix type annotations in `lib/tool_shed/test/base/populators.py` - Fix typo bug in `test/unit/util/test_get_url.py`
4 tasks
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
May 22, 2024
introduced in galaxyproject#18003 . In particular, when using requests in the tests to connect to Galaxy or the ToolShed it's not needed to use the modified headers. Also: - Move some imports after conditional imports. - Fix type annotations in `lib/tool_shed/test/base/populators.py` - Fix typo bug in `test/unit/util/test_get_url.py`
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
May 23, 2024
introduced in galaxyproject#18003 . In particular, when using requests in the tests to connect to Galaxy or the ToolShed it's not needed to use the modified headers. Also: - Move some imports after conditional imports. - Fix type annotations in `lib/tool_shed/test/base/populators.py` - Fix typo bug in `test/unit/util/test_get_url.py`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #17578 but avoids global manipulation of requests. Should eventually also fix #17995
How to test the changes?
(Select all options that apply)
License