Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Workflow API routes - Part 3 #17978

Draft
wants to merge 105 commits into
base: dev
Choose a base branch
from
Draft

Refactor Workflow API routes - Part 3 #17978

wants to merge 105 commits into from

Conversation

heisner-tillman
Copy link
Contributor

@heisner-tillman heisner-tillman commented Apr 12, 2024 •
edited

This is a part of #10889 and an extension of #17463 and #17548.

Summary

  • Refactored API routes:
    • PUT: api/workflows/{workflow_id} POST /api/workflows
      • Added pydantic models to input
      • Added pydantic models to return
      • Removed the mapping to the legacy route
    • POST /api/workflows
      • Added pydantic models to input
      • Added pydantic models to return
      • Removed the mapping to the legacy

How to test the changes?

  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    You can find the interactive API documentation here:

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@heisner-tillman heisner-tillman marked this pull request as draft April 12, 2024 15:25
@github-actions github-actions bot added this to the 24.1 milestone Apr 12, 2024
@heisner-tillman heisner-tillman changed the title Workflows Refactor Workflow API routes - Part 2 Apr 15, 2024
@heisner-tillman heisner-tillman changed the title Refactor Workflow API routes - Part 2 Refactor Workflow API routes - Part 3 Apr 15, 2024
@heisner-tillman heisner-tillman force-pushed the workflows branch 2 times, most recently from 85b4a9e to 90f8c92 Compare May 11, 2024 15:02
@mvdbeek mvdbeek removed this from the 24.1 milestone May 14, 2024
@heisner-tillman heisner-tillman force-pushed the workflows branch 2 times, most recently from ce7dafb to 773f11f Compare May 29, 2024 10:59
@heisner-tillman
Add set_workflow_menu method to service layer of the Workflows API
e5808b5
@heisner-tillman
Create pydantic models for the set_workflow_menu operation of the Wor…
6e2b9dd 
…kflowsAPI
@heisner-tillman
Refactor set_workflow_menu operation to FastAPI
1847e55
@heisner-tillman
Remove the mapping to the legacy route
c3c9059
@heisner-tillman
Add TODO
3e52ee7
@heisner-tillman
Type payload of set_workflow_menu operation properly
f1a281c
@heisner-tillman
Regenerate the client schema
8f648d5
@heisner-tillman
Mark HistoryId query param as invocation specific
5143613
@heisner-tillman
Refactor workflow_dict operation to FastAPI
a95c1db
@heisner-tillman
Create service method for workflow_dict operation
2a10497
@heisner-tillman
Remove mapping to legacy routes
f459508
@heisner-tillman
Regenerate the client schema
5e25a4e
@heisner-tillman
Remove unused internal method in legacy WorkflowsAPIController
be4f571
@heisner-tillman
Use the correct get_workflow method from WorkflowsManager
167562f
@heisner-tillman
Type yaml return of download_workflow method
3be5db6
@heisner-tillman
Remove unused imports
2370aee
@heisner-tillman
Add pydantic model to return of update operation
7f03a11
@heisner-tillman
Fix creating worfklow_dict in the service method of update operation
590267b
@heisner-tillman
Add missing fields to payload of update operation
e3e42d5
@heisner-tillman
Change instance that will be passed to sa_session via add in service …
161fc71 
…method of update operation
@heisner-tillman
Add json key word to tests
deb5d59
@heisner-tillman
Extend the payload model of the create oepration
e7eaeb6
@heisner-tillman
Refactor the create operation and move several helper methods to the …
f35d87f 
…service layer
@heisner-tillman
Add json keyword when posting to route 'workflows' in tests
441a4c7
@heisner-tillman
Regenerate the client schema
df2a232
@heisner-tillman
Add more fields to field_validator that decodes json fields in payloa…
df97990 
…d of create method
@heisner-tillman
Regenerate the client schema
fc2bef0
@heisner-tillman
Allow integer type for some id fields in payload model of create oper…
dd0b8c8 
…ation
@heisner-tillman
Add possibility to load app from trans in get_stored_workflow method
a8a765d
@heisner-tillman
Remove leftovers from debugging create method in workflow service layer
800cd26
@heisner-tillman
Remove unused internal method of WorkflowAPIController
8e6a6bf
@heisner-tillman
Fix typing of id fields in payload of create opperation
f52ccb7
@heisner-tillman
Fix typing of field upgrade_messages in one of the return models of t…
2fb5875 
…he workflow_dict operation
@heisner-tillman
Fix typing of field upgrade_messages in return model of workflow_dict…
4c0697b 
… operation
@heisner-tillman
Regenerate the client schema
52a843e
@heisner-tillman
Reuse unused import
d8f08e2
@heisner-tillman
Add more fields to the payload of the create method
94fe4c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/API area/testing/api area/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heisner-tillman @mvdbeek