-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Masthead Revision #17927
Open
guerler
wants to merge
53
commits into
galaxyproject:dev
Choose a base branch
from
guerler:masthead_update
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Masthead Revision #17927
+541
−948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerler
force-pushed
the
masthead_update
branch
from
April 18, 2024 15:26
d3da428
to
e2180d5
Compare
guerler
force-pushed
the
masthead_update
branch
3 times, most recently
from
May 21, 2024 15:28
c1e2d21
to
88a981b
Compare
guerler
changed the title
Explores revising and removing redundant Masthead items with regard to the Activity bar
Revises and removes redundant Masthead items with regard to the Activity bar
May 28, 2024
guerler
added
kind/enhancement
area/UI-UX
and removed
area/admin
area/testing
area/testing/selenium
labels
May 29, 2024
guerler
changed the title
Revises and removes redundant Masthead items with regard to the Activity bar
Masthead Revision
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to achieve consistency and reduce redundancy in the Masthead and align its functionality with the Activity Bar. The PR also contains improvements to the Activity Bar and Masthead as recently discussed during the UX team meeting.
@mvdbeek suggested that hidden and less frequently used activities should still be readily accessible. To account for that, the
Settings
activity has been replaced with aMore
activity. Users may still use this activity to add or remove items from the activity bar. Additionally, now users may also directly navigate to any activity using this panel.@davelopez suggested that the username should be visible to the user and that accessing user preferences should remain in the masthead dropdown. This idea has been implemented, the username has been added to the masthead, user preferences and logout are accessible through the user tab.
Resolves #17476, #17109, #17513.
Screen.Recording.2024-06-01.at.8.26.10.AM.mov
How to test the changes?
(Select all options that apply)
License