Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masthead Revision #17927

Open
wants to merge 53 commits into
base: dev
Choose a base branch
from
Open

Masthead Revision #17927

wants to merge 53 commits into from

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Apr 7, 2024

The goal of this PR is to achieve consistency and reduce redundancy in the Masthead and align its functionality with the Activity Bar. The PR also contains improvements to the Activity Bar and Masthead as recently discussed during the UX team meeting.

  1. @mvdbeek suggested that hidden and less frequently used activities should still be readily accessible. To account for that, the Settings activity has been replaced with a More activity. Users may still use this activity to add or remove items from the activity bar. Additionally, now users may also directly navigate to any activity using this panel.

  2. @davelopez suggested that the username should be visible to the user and that accessing user preferences should remain in the masthead dropdown. This idea has been implemented, the username has been added to the masthead, user preferences and logout are accessible through the user tab.

Resolves #17476, #17109, #17513.

Screen.Recording.2024-06-01.at.8.26.10.AM.mov

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler force-pushed the masthead_update branch 3 times, most recently from c1e2d21 to 88a981b Compare May 21, 2024 15:28
@guerler guerler changed the title Explores revising and removing redundant Masthead items with regard to the Activity bar Revises and removes redundant Masthead items with regard to the Activity bar May 28, 2024
@guerler guerler added this to the 24.2 milestone Jun 1, 2024
@guerler guerler changed the title Revises and removes redundant Masthead items with regard to the Activity bar Masthead Revision Jun 3, 2024
@dannon dannon self-requested a review June 4, 2024 16:27
@guerler guerler marked this pull request as ready for review June 5, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

clarify the visual language of selected masthead vs activity bar
1 participant