Adding Help Mode to Galaxy #17805
Draft
Adding Help Mode to Galaxy #17805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedhamidawan
force-pushed
the
13221/help-mode-third-attemptt
branch
from
da607fd
to
01b38cd
Compare
4 tasks
- Added a tab view for help mode which tracks the current, relevant help texts using a stack. - Consolidated multiple help stores into one. - Used an existing composable for MD rendering. - Modified the composable to use the html prop, add `<hr>`s in `<details>` sections and render font awesome icons wherever there is a `<code>fa-iconname</code>` section. - Other help mode related minor refactoring
Still toggleable into a draggable mode if needed
ahmedhamidawan
force-pushed
the
13221/help-mode-third-attemptt
branch
from
f968cc8
to
6cc94ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new draft of Help Mode, because of updates to dev, rebasing got messy and hard to do. It includes all previous changes in #17168 and #16630, plus some minor changes to how the help mode box functions (x to close, draggable)
What still needs to be done:
How to test the changes?
(Select all options that apply)
License