Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22.05] Update cryptography to 38.0.3 #14904

Merged
merged 1 commit into from Nov 2, 2022

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Nov 1, 2022

Includes an update to the bundled OpenSSL to version 3.0.7 for CVE-2022-3602.

The vulnerability is largely unexploitable but updating is good practice regardless. OpenSSL 3 was introduced in cryptography 37, and 22.01 uses 36, so older Galaxy versions are unaffected. I'm working on a blog post as well.

xref pyca/cryptography#7758

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.1 milestone Nov 1, 2022
@nsoranzo nsoranzo changed the title Update cryptography to 38.0.3 [22.05] Update cryptography to 38.0.3 Nov 1, 2022
@nsoranzo
Copy link
Member

nsoranzo commented Nov 1, 2022

Mulled unit tests and Galaxy packages (py3.10) failures are not related and have been fixed on the dev branch.

@natefoo
Copy link
Member Author

natefoo commented Nov 1, 2022

@nsoranzo thanks! The first failure was actually with accessing depot, which was temporal and cleared up after a rerun, but I wasn't sure about the remaining failure.

@nsoranzo nsoranzo merged commit aebda69 into galaxyproject:release_22.05 Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

This PR was merged without a "kind/" label, please correct.

@hexylena
Copy link
Member

hexylena commented Nov 2, 2022

Can this should be backported to 22.01 as well, since that's still under our "year of security fixes" umbrella?

@bgruening
Copy link
Member

I think 22.01 includes a version that is not affected. The version that we pinned at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants