[22.05] Fix delayed optional data input handling #14641
Conversation
This fixes recording optional data input module use in the expanded tool form (and is closer to how we want to use the API). Fixes galaxyproject#14611
Tool and subworkflow steps can have replacement parameters
…ultStep to WorkflowInputStep I think these are better names that describe what they are used for.
|
Is that still draft? |
|
Yep, still needs tests, and I want to check out what's up with #10899 (comment). You shouldn't have to specify optional inputs in the API submission at all. |
mvdbeek
changed the title
|
https://github.com/galaxyproject/galaxy/actions/runs/3089464955/jobs/4997115418#step:7:1442 should be unrelated, we might have to pin numpy to a version that works on python 3.7 |
|
The unit tests failures seems related though? |
No, it's actually a mypy bug, whose fix will be included in the upcoming mypy 0.980. |
|
Just waiting for the API tests to finish before pushing the unit test fix. |
This is the core of the backend fix and allows omitting optional workflow inputs from the API. This somewhat worked previously when `recover_mapping` didin't have to be called, but failed when a step had to be delayed.
mvdbeek
force-pushed
the
fix_optional_data_input_submission_expanded_tool_form
branch
from
ed5a007
to
17f3647
Compare
|
@jmchilton this has changed a bit from when you approved it, does it still look ok to you? |
|
Awesome thank you. |
nsoranzo
deleted the
fix_optional_data_input_submission_expanded_tool_form
branch
This fixes recording optional data input module use in the expanded tool form (and is closer to how we want to use the API).
It also fixes scheduling workflows where optional input steps are being delayed, and it allows leaving subworkflow optional data inputs disconnected.
Fixes #14611, #10899, #10450
How to test the changes?
(Select all options that apply)
License