Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary downgrade FastAPI to v0.68.2 #12856

Merged

Conversation

davelopez
Copy link
Contributor

Follow up on #12836

There are no breaking changes in FastAPI v0.70.0 but that version pins Starlette to v0.16.0 which, in some circumstances, raises anyio.BrokenResourceError. See details in #12836 (comment).
This is apparently addressed in Starlette v0.17.0 but since we cannot update to that version yet maybe is better to go back a couple of versions until a new version of FastAPI is released.

How to test the changes?

  • This is a refactoring of components with existing test coverage.

License

@github-actions github-actions bot added this to the 22.01 milestone Nov 4, 2021
@nsoranzo
Copy link
Member

nsoranzo commented Nov 4, 2021

Does FastAPI 0.69.0 with Starlette 0.15.0 also have the same problem?

@davelopez
Copy link
Contributor Author

Does FastAPI 0.69.0 with Starlette 0.15.0 also have the same problem?

Yeah, I think so because of this comment encode/starlette#1284 (comment)

@nsoranzo nsoranzo merged commit 58693d6 into galaxyproject:dev Nov 4, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This PR was merged without a "kind/" label, please correct.

@davelopez davelopez deleted the temporary_downgrade_fastapi_version branch November 4, 2021 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants