[21.05] Wait for uploaded datasets in API tests #12144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most methods that stage datasets already do that anwyway. Might be nice in the future if we could just cancel running jobs at the end of a test and not wait for uploads where not necessary, but this should increase test stability in the short term. Fixes galaxyproject#12136 (comment)
mvdbeek
force-pushed
the
wait_for_uploaded_datasets
branch
from
d5ba389
to
8008c36
Compare
jmchilton
reviewed
Sep 8, 2021
| @@ -1573,6 +1573,7 @@ def __datasets(self, history_id, count, contents=None): | |||
| if contents: | |||
| new_kwds["content"] = contents[i] | |||
| datasets.append(self.dataset_populator.new_dataset(history_id, **new_kwds)) | |||
There was a problem hiding this comment.
Can just pass wait=True here I guess instead.
|
We're largely doing that now that we've switched to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most methods that stage datasets already do that anyway. Might be nice
in the future if we could just cancel running jobs at the end of a test
and not wait for uploads where not necessary, but this should increase
test stability in the short term.
Fixes #12136 (comment)
How to test the changes?
(Select all options that apply)
License