Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FastAPI routes for Library Folders #12131

Merged
merged 9 commits into from
Jul 1, 2021
Merged

Add FastAPI routes for Library Folders #12131

merged 9 commits into from
Jul 1, 2021

Conversation

davelopez
Copy link
Contributor

This is part of the efforts to migrate the full Galaxy API to FastAPI see #10889.

This PR also moves some existing pydantic models to the lib/galaxy/schema/schema.py module as discussed in the Gitter channel for better reusability.

How to test the changes?

  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    • It can be also manually tested using the API interactive documentation available at http://localhost:8080/api/docs/

Screenshot from 2021-06-11 20-03-06

License

@github-actions github-actions bot added this to the 21.09 milestone Jun 11, 2021
@davelopez davelopez marked this pull request as draft June 11, 2021 21:58
@davelopez davelopez added kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes labels Jun 12, 2021
@davelopez davelopez marked this pull request as ready for review June 12, 2021 12:48
@davelopez davelopez marked this pull request as draft June 15, 2021 18:18
@davelopez
Copy link
Contributor Author

davelopez commented Jun 21, 2021 •
edited

Waiting for #12152 to fix the Content-Type issue Done!

@davelopez
Move some pydantic models to lib/galaxy/schema/schema.py
f2e3386 
This should simplify the imports and will allow to reuse the models or decompose them more easily
@davelopez
Unify library folder API tests to use JSON
eaca2c8
@davelopez
Add pydantic models for library folders
c4f3376
@davelopez
Remove custom update_time format
a20fee4 
The time format should be handled by the client and the serialization will be made in the pydantic model, so we can remove this `strftime`
@davelopez
Add type annotations to the FoldersService
3d17cb3
@davelopez
Add FastAPI endpoints for library folders API
d8a930d
@davelopez
Fix set_permissions legacy endpoint
0c3abff 
When the `action` was defined directly in the query parameters instead of the request body it wasn't getting to the manager.
@davelopez
Fix folder contents API tests
20412aa 
Some more tests using POST didn't send the request in JSON format.
@davelopez
Fix API tests by explicitly setting content-type to JSON
1b47ec9 
See galaxyproject#12152
@davelopez davelopez marked this pull request as ready for review June 25, 2021 13:15
@bgruening bgruening requested a review from jmchilton July 1, 2021 19:38
@jmchilton jmchilton merged commit 1efff5e into galaxyproject:dev Jul 1, 2021
@jmchilton
Copy link
Member

Awesome - looks like solid refactorings to me! Thanks so much.

@jmchilton jmchilton mentioned this pull request Jul 1, 2021
Merged
3 tasks
@davelopez davelopez deleted the fastapi_library_folders branch July 2, 2021 07:07
@bgruening bgruening mentioned this pull request Jul 2, 2021
Open
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton Awaiting requested review from jmchilton

Assignees
No one assigned
Labels
area/API area/libraries Data libraries area/testing/api area/testing kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
21.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davelopez @jmchilton