fix: return error when failing to decode output in parse_call_result #2691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I ran into this issue when trying to decode the output for a call where the ABI had the incorrect type. I was calling many different ERC20 contracts for
symbol()
but found a contract that has a different return type,bytes32
instead of the expectedstring
.Without this change it's hard to understand which call is failing because the entire Multicall returns an error instead of individually for each call.
Solution
parse_call_result
now returnsErr(bytes)
for each call output that fails to decode. It previously just returned anErr
immediately from the failing decode function due to?
.Not sure if it's still ideal to just return
bytes
sincecall
andcall_array
will assume it's a revert.The resulting different behaviour is that instead getting an error for
call_raw()
you would get an error when parsing the results similar to a regular revert error for example.PR Checklist