feat: eth_callMany #2664
Open
feat: eth_callMany #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Nov 6, 2023
|
|
||
| #[derive(Serialize, Debug, Clone)] | ||
| pub struct EthCallManyBalanceDiff { | ||
| pub balance: U256, |
There was a problem hiding this comment.
I'd like to have this as Option, in case we need more fields
|
Going to update as per code review comments |
|
Updated PR as per code review comments - added 2 basic examples |
mattsse
requested changes
Nov 7, 2023
Comment on lines
+32
to
+33
| #[derive(Serialize, Deserialize, Debug, Clone)] | ||
| pub struct EthCallManyOutputEmpty {} |
| #[derive(Serialize, Deserialize, Debug, Clone)] | ||
| pub struct EthCallManyOutput { | ||
| pub value: Option<Bytes>, | ||
| pub error: Option<EthCallManyOutputEmpty>, |
|
can we get a sample response for a test? |
|
overrides object lacks some fields I believe: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Missing feature, I had written it initially for my own project using (ledgerwatch/erigon#4471) as reference and thought I would implement it here
Solution
Add eth_callMany function to support simulating a set of bundles
PR Checklist