Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added blockoverride field in geth tracing call options #2603

Merged

Conversation

lakshya-sky
Copy link
Contributor

@lakshya-sky lakshya-sky commented Sep 15, 2023

Fixes #2604

Motivation

Allow to override block params for debug_traceCall which would in turn allow to trace a pending txn against pending block.

Solution

Added BlockOverrides fields which is similar to following impls.

https://github.com/ethereum/go-ethereum/blob/16cd1a7561155a264b1a1a2a5850b11c47dc18d4/internal/ethapi/api.go#L993
https://paradigmxyz.github.io/reth/docs/reth/rpc/types/struct.BlockOverrides.html

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

please update failing test @lakshya-sky

@lakshya-sky
Copy link
Contributor Author

@mattsse updated

@DaniPopes DaniPopes merged commit cdb7802 into gakonst:master Sep 25, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow blockoverrieds for debug_traceCall
3 participants