Upgrade to Tokio 1.0 and remove async-std #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING: This removes async-std as a compatibility option
* feat(core): move to bytes::Bytes * feat: adjust rest of crates to Bytes
gakonst
force-pushed
the
feat/tokio-1.0
branch
from
3a9b0ef
to
96d53f1
Compare
CI fails due to: snapview/tokio-tungstenite#142 (comment)
gakonst
force-pushed
the
feat/tokio-1.0
branch
from
96d53f1
to
34b6222
Compare
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #114
Solution
Updates deps to Tokio 1.0. Async-std is no longer a dep.
Blocked on reqwest and tokio-tungstenite releases: