Add option to disable wrapping text #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 232
💛 - Coveralls |
IanEdington
force-pushed
the
ian.add.option.to.disable.wrapping
branch
from
3cb6b38
to
099dfdb
Compare
|
I can see the use case for this. |
|
Cool! I'm happy to flesh out this PR if it's likely to get merged also running into an issue with |
|
The build is now working. |
|
@IanEdington If you rebase, the CI/CD is now working as expected. |
When width is set, cell text is always wrapped. In some cases this is undesirable. For example adding formating that will shrink the effective size of the cell. see gajus#117
IanEdington
force-pushed
the
ian.add.option.to.disable.wrapping
branch
from
4cd92e6
to
fb30b3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When width is set, cell text is always wrapped. In some cases this is
undesirable. For example adding formatting that will shrink the effective
size of the cell. see #117
This is a quick and dirty PR to get started on this feature.
Obviously tests and docs are needed, just wanted to get feedback before going further.
disableWrapis a boolean option on columns that allows bypassing the text wrap functions altogether.