Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable wordWrap altogether (willing to implement) #117

Open
IanEdington opened this issue Aug 12, 2020 · 1 comment
Open

Comments

@IanEdington
Copy link
Contributor

I have links in my table that are being parsed by a parser (Slack).
Currently this makes the tables have a huge amount of space on the linked

╔═════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════╤═══════════╤══════════════╤══════════════╗
║ Setting                                                                                                                                         │ Values    │ Last updated │ Authored     ║
╟─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼───────────┼──────────────┼──────────────╢
║ SOME_SETTING_NAME │ 50% true  │ 19 months    │ Jan 10, 2019 ║
╚═════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════════╧═══════════╧══════════════╧══════════════╝

currently using width, with or without wordWrap enabled give this:

╔══════════════════════════════════════════════════╤═══════════╤══════════════╤══════════════╗
║ Setting                                          │ Values    │ Last updated │ Authored     ║
╟──────────────────────────────────────────────────┼───────────┼──────────────┼──────────────╢
║ <https://www.a_very_long_url_that_just_keeps_goi │ 50% true  │ 19 months    │ Aug 10, 2019 ║
║ ng_and_finally.stops?q=SOME_SETTING_NAME|SOME_SE │           │              │              ║
║ TTING_NAME>                                      │           │              │              ║
╚══════════════════════════════════════════════════╧═══════════╧══════════════╧══════════════╝

Which totally makes sense as a default.

I would link to add an option that sets the width but disables wrapping altogether.

This option could either be overloading wordWrap aka wordWrap='disable' or a new flag like disableWordWrap.

Are you open to adding another option for this use case?
Looking for feedback before implementing.

PS thanks for a great tool

IanEdington added a commit to IanEdington/table that referenced this issue Aug 12, 2020
When width is set, cell text is always wrapped. In some cases this is
undesirable. For example adding formating that will shrink the effective
size of the cell. see gajus#117
IanEdington added a commit to IanEdington/table that referenced this issue Aug 12, 2020
When width is set, cell text is always wrapped. In some cases this is
undesirable. For example adding formating that will shrink the effective
size of the cell. see gajus#117
IanEdington added a commit to IanEdington/table that referenced this issue Jan 3, 2021
When width is set, cell text is always wrapped. In some cases this is
undesirable. For example adding formating that will shrink the effective
size of the cell. see gajus#117
@nam-hle
Copy link
Collaborator

nam-hle commented May 2, 2021

Hi @IanEdington, it seems that you don't have enough time to work on the PR. I'm willing to help you but honestly I don't understand what you expects. Can you show me your expected output?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants