Options for checking getter or setter only #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettz9
force-pushed
the
check-getter-setter-only
branch
8 times, most recently
from
740f2ec
to
90d02f9
Compare
brettz9
force-pushed
the
check-getter-setter-only
branch
from
90d02f9
to
d78be4e
Compare
|
🎉 This PR is included in version 32.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require-jsdoc): allow checking for getter or setter only; fixes [require-jsdoc] Require JSDoc only either for the getter or the setter #515Although I know normally @gajus and @golopot did not favor options whose schemas allowed different types, given that
checkGetters/checkSettershas been around as a boolean for a while, and adding a separatecheckGettersWithSettesr/checkSettersWithGettersboolean option could become a confusing headache, this PR does allow a string value forcheckGetters/checkSetters.