feat(require-param): change fixer to fix all missing tags at once
#404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yeonjuan
commented
Oct 17, 2019
•
yeonjuan
commented
- @brettz9 - This is PR for 1, 2
|
Although ESLint runs fixes in multiple passes and so this may technically seem unnecessary, I think there is still an advantage to such changes as these since it makes the documentation more clear when we indicate the expected output as having fixed all items. I hope we may do so with all the fixers in the future and update tests to show this. Re: my destructuring concern, I pushed an additional commit to get satisfaction on that (it is safely ignored for now no matter the position). Thanks very much! Great work as usual! |
|
🎉 This PR is included in version 15.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.