Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ignore examples in check-indentation #388

Merged

Commits on Sep 30, 2019

  1. fix(check-indentation): ignore example code blocks

    This adds an `excludeExamples` option, defaulting to `true`.
    When enabled (or not configured) it will mask all `@example` tags
    and their content before testing indentation.
    That prevents errors about indentation inside example code
    blocks and keeps correct line numbers when reporting indentation error
    found elsewhere.
    
    It should fix gajus#334.
    ahwayakchih committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    57e2a54 View commit details
    Browse the repository at this point in the history
  2. fix(check-indentation): update README, default to false, lint ok

    Ideally this would default to `true`, but that could break existing setups.
    ahwayakchih committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    374ef7d View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2019

  1. fix(check-indentation): excludeTags option, add tests, default on

    Instead of rather specific `excludeExamples` option, we now have more
    generic `excludeTags` option. It takes an array of tag names to exclude
    from `check-indentation`, and defaults to `['example']`.
    
    Added test suggested by @golopot:
    gajus#388 (comment)
    ahwayakchih committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    b00b899 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    62db652 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9ad7e5f View commit details
    Browse the repository at this point in the history