Skip to content

Commit

Permalink
chore: require engines Node 12+
Browse files Browse the repository at this point in the history
BREAKING CHANGE:

Also:
- Build: Switch to Node 12 target
- Linting: Use `flat` API
- Travis: Add Node 16, remove Node 10
- npm: Update devDep.
  • Loading branch information
brettz9 committed May 9, 2021
1 parent c236ed8 commit fd91593
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .babelrc.json
Expand Up @@ -9,7 +9,7 @@
"@babel/preset-env",
{
"targets": {
"node": 10
"node": 12
}
}
]
Expand Down
2 changes: 1 addition & 1 deletion .travis.yml
Expand Up @@ -2,9 +2,9 @@ os: linux
dist: xenial
language: node_js
node_js:
- 16
- 14
- 12
- 10

before_install:
- npm config set depth 0
Expand Down
4 changes: 2 additions & 2 deletions package.json
Expand Up @@ -36,15 +36,15 @@
"gitdown": "^3.1.4",
"glob": "^7.1.7",
"husky": "^6.0.0",
"lint-staged": "^10.5.4",
"lint-staged": "^11.0.0",
"mocha": "^8.4.0",
"nyc": "^15.1.0",
"rimraf": "^3.0.2",
"semantic-release": "^17.4.2",
"typescript": "^4.2.4"
},
"engines": {
"node": ">=10"
"node": ">=12"
},
"lint-staged": {
".eslintignore": "npm run lint",
Expand Down
5 changes: 1 addition & 4 deletions src/jsdocUtils.js
Expand Up @@ -325,10 +325,7 @@ const isValidTag = (
) : boolean => {
const tagNames = getTagNamesForMode(mode, context);

// Todo[engine:node@>=12]: Switch to flatten

// eslint-disable-next-line unicorn/prefer-array-flat -- Not yet supported
const validTagNames = Object.keys(tagNames).concat(_.flatten(Object.values(tagNames)));
const validTagNames = Object.keys(tagNames).concat(Object.values(tagNames).flat());
const additionalTags = definedTags;
const allTags = validTagNames.concat(additionalTags);

Expand Down

0 comments on commit fd91593

Please sign in to comment.