New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check if the channel is closed before returning ws.result to prevent panic #198

Open

mhughdo wants to merge 1 commit into gagliardetto:main from mhughdo:fix/check-for-closed-channel-before-returning

mhughdo commented Apr 21, 2024

Overview

If sub.Unsubscribe() func is not called properly, it could cause panic:
panic: interface conversion: ws.result is nil, not *ws.LogResult
It's due to Recv() receiving values from the closed channel. I think it's better to handle this case instead of letting it panic.

Changes

Checking if the channel is closed before returning the value.


          fix: check if the channel is closed before returning ws.result

2a50488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment