Check for negative nums

gagliardetto · Apr 17, 2024 · 0b9c4d7 · 0b9c4d7
1 parent 6a20387
commit 0b9c4d7
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/transaction.go b/transaction.go
@@ -505,6 +505,9 @@ func (tx *Transaction) UnmarshalWithDecoder(decoder *bin.Decoder) (err error) {
 		if err != nil {
 			return fmt.Errorf("unable to read numSignatures: %w", err)
 		}
+		if numSignatures < 0 {
+			return fmt.Errorf("numSignatures is negative")
+		}
 		if numSignatures > decoder.Remaining()/64 {
 			return fmt.Errorf("numSignatures %d is too large for remaining bytes %d", numSignatures, decoder.Remaining())
 		}