Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added @hot-loader/react-dom which is missing #1358

Merged
merged 2 commits into from Oct 12, 2019
Merged

Conversation

theajr
Copy link
Contributor

@theajr theajr commented Oct 11, 2019

@gaearon

In examples/typescript, @hot-loader/react-dom was missing in package.json which is required as we are using it as alias for react-dom.
Fixed some auto fixable vulnerabilities by running npm audit fix

@theKashey
Copy link
Collaborator

package.lock is not supposed to be here 😅

@theajr
Copy link
Contributor Author

theajr commented Oct 12, 2019

@theKashey Removed package lock file!

@theKashey theKashey merged commit 18802fb into gaearon:master Oct 12, 2019
@theKashey
Copy link
Collaborator

Good job!
There is another TypeScript related issue you might like - #1359 (but you don't have to)

@theajr
Copy link
Contributor Author

theajr commented Oct 12, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants