Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added new provenance options for docker.buildx.build() #410

Merged
merged 6 commits into from
Feb 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 25 additions & 0 deletions python_on_whales/components/buildx/cli_wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,24 +206,33 @@ def build(
context_path: ValidPath,
add_hosts: Dict[str, str] = {},
allow: List[str] = [],
attest: Optional[Dict[str, str]] = None,
build_args: Dict[str, str] = {},
# TODO: build_context
builder: Optional[ValidBuilder] = None,
cache: bool = True,
# TODO: cache_filters
cache_from: Union[str, Dict[str, str], List[Dict[str, str]], None] = None,
cache_to: Union[str, Dict[str, str], None] = None,
# TODO: cgroup_parent
file: Optional[ValidPath] = None,
labels: Dict[str, str] = {},
load: bool = False,
# TODO: metadata_file
network: Optional[str] = None,
output: Dict[str, str] = {},
platforms: Optional[List[str]] = None,
progress: Union[str, bool] = "auto",
provenance: Union[bool, Dict[str, str], None] = None,
pull: bool = False,
push: bool = False,
sbom: Union[bool, Dict[str, str], None] = None,
secrets: Union[str, List[str]] = [],
# TODO shm_size
ssh: Optional[str] = None,
tags: Union[str, List[str]] = [],
target: Optional[str] = None,
# TODO: ulimit
stream_logs: bool = False,
) -> Union[
None, python_on_whales.components.image.cli_wrapper.Image, Iterator[str]
Expand All @@ -242,6 +251,7 @@ def build(
add_hosts: Hosts to add. `add_hosts={"my_host1": "192.168.32.35"}`
allow: List of extra privileges.
Eg `allow=["network.host", "security.insecure"]`
attest: Attestation parameters. Eg `attest={"type": "sbom", "generator": "my_image"}`
build_args: The build arguments.
ex `build_args={"PY_VERSION": "3.7.8", "UBUNTU_VERSION": "20.04"}`.
builder: Specify which builder to use.
Expand Down Expand Up @@ -273,8 +283,13 @@ def build(
`platforms=["linux/amd64", "linux/arm64"]`
progress: Set type of progress output (auto, plain, tty, or False).
Use plain to keep the container output on screen
provenance: Shortand for `attest={"type": "provenance"}`.
Eg `provenance=True` or `provenance=dict(mode="max")`. `provenance=False` might be needed
if you are having the
issue [Default image output from buildx v0.10 cannot run on Google Cloud Run or AWS Lambda](https://github.com/docker/buildx/issues/1533)
pull: Always attempt to pull a newer version of the image
push: Shorthand for `output=dict(type="registry")`.
sbom: Shorthand for `attest={"type": "sbom"}`. Eg `sbom=True`.
secrets: One or more secrets passed as string(s). For example
`secrets="id=aws,src=/home/my_user/.aws/credentials"`
ssh: SSH agent socket or keys to expose to the build
Expand All @@ -299,14 +314,24 @@ def build(
"--add-host", format_dict_for_cli(add_hosts, separator=":")
)
full_cmd.add_args_list("--allow", allow)
if isinstance(attest, dict):
full_cmd.add_simple_arg("--attest", format_dict_for_buildx(attest))
full_cmd.add_args_list("--build-arg", format_dict_for_cli(build_args))
full_cmd.add_simple_arg("--builder", builder)
full_cmd.add_args_list("--label", format_dict_for_cli(labels))

full_cmd.add_simple_arg("--ssh", ssh)

if isinstance(provenance, bool):
full_cmd.append(f"--provenance={str(provenance).lower()}")
elif isinstance(provenance, dict):
full_cmd.add_simple_arg("--provenance", format_dict_for_buildx(provenance))
full_cmd.add_flag("--pull", pull)
full_cmd.add_flag("--push", push)
if isinstance(sbom, bool):
full_cmd.append(f"--sbom={str(sbom).lower()}")
elif isinstance(sbom, dict):
full_cmd.add_simple_arg("--sbom", format_dict_for_buildx(sbom))
full_cmd.add_flag("--load", load)
full_cmd.add_simple_arg("--file", file)
full_cmd.add_simple_arg("--target", target)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,21 @@ def test_multiarch_build(tmp_path, docker_registry):
docker.pull(f"{docker_registry}/dodo:1")


@pytest.mark.usefixtures("with_container_driver")
@pytest.mark.parametrize(
"kwargs",
[
dict(sbom=True),
dict(provenance=True),
dict(attest=dict(type="provenance", mode="min")),
dict(provenance=dict(mode="max")),
],
)
def test_buildx_build_attestations(tmp_path, kwargs):
(tmp_path / "Dockerfile").write_text(dockerfile_content1)
docker.buildx.build(tmp_path, **kwargs)


def test_buildx_build_context_manager2(tmp_path):
(tmp_path / "Dockerfile").write_text(dockerfile_content1)
buildx_builder = docker.buildx.create()
Expand Down