This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Add hslColor to ColorProvider #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will add hslColor and hslColorAsArray for ColorProvider Should solve #1720
localheinz
reviewed
Aug 27, 2019
There was a problem hiding this comment.
This looks good to me!
One more thing though before I can approve: Can you update readme.md, please?
| @@ -113,4 +113,26 @@ public static function colorName() | |||
| { | |||
| return static::randomElement(static::$allColorNames); | |||
| } | |||
|
|
|||
| /** | |||
| * @example '340,50,20' | |||
There was a problem hiding this comment.
What do you think about adding a @return annotation with array as type here?
There was a problem hiding this comment.
Its more like string. But I added it :)
| ); | ||
| } | ||
|
|
||
| public static function hslColorAsArray() |
There was a problem hiding this comment.
What do you think about adding a @return annotation with array as type here?
Sure thing, totally forgot about that. 👍 |
fzaninotto
approved these changes
Aug 27, 2019
|
Thank you, @icanhazstring! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add
hslColorandhslColorAsArrayforColorProviderCloses #1720