This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Improve Dutch company names #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@koole thanks! Could you please rebase your branch in order to resolve the conflict? |
|
@pimjansen I've rebased my branch and resolved a phpcs linting issue that appeared for the switch statement. |
pimjansen
approved these changes
Aug 28, 2019
|
@koole looks great thanks! |
|
Thank you, @koole! |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously generated company names only consisted of one or two surnames and a suffix. This resulted in unrealistic and sometimes extremely long company names like "de la Fontaine und d’Harnoncourt Unverzagt Mohan EESV" and "Martena van Burmania Vegilin van Claerbergen".
The new faker generates realistic company names like "Fietsenmaker Zijlemans" and "Elektronicakampioen BV".