Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update target for November 2022 Google Play requirement #3383

Merged
merged 2 commits into from Nov 15, 2022
Merged

Update target for November 2022 Google Play requirement #3383

merged 2 commits into from Nov 15, 2022

Conversation

andydotxyz
Copy link
Member

Fixes #3375

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Nov 6, 2022 •
edited

Coverage Status

Coverage decreased (-0.02%) to 61.688% when pulling 4a89752 on andydotxyz:fix/3375 into cae867c on fyne-io:develop.

@andydotxyz
Copy link
Member Author

Looks like we also need to add android:exported="true" ... looking in to it

Jacalz
Jacalz previously approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no device to test on but it is a very tiny change and seems to make sense

@andydotxyz
Copy link
Member Author

Sorry @Jacalz I needed to include the second point noted more recently on the ticket

@andydotxyz andydotxyz merged commit 8c34417 into fyne-io:develop Nov 15, 2022
@andydotxyz andydotxyz deleted the fix/3375 branch November 15, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andydotxyz @coveralls @Jacalz