Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split container hidden sizing #3348

Merged
merged 2 commits into from Oct 22, 2022
Merged

Split container hidden sizing #3348

merged 2 commits into from Oct 22, 2022

Conversation

itsjustdel
Copy link
Contributor

Description:

Addresses Split Container not respecting item's visible status if item is not in a container. When calculating the size of each split, my fix checks if the item is visible and returns a size of 0 if not.

Fixes #3232

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@itsjustdel
Visibility check for sizing
dc25d62 
These checks are only required if the widget does not have container. If a parent container is present, the container checks for child visibility when working out it's MinSize.
@itsjustdel
Test for hidden widget
3ee7c91
Bluebugs
Bluebugs previously approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@Bluebugs Bluebugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does make sense actually, and there is tests \o/

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 61.471% when pulling 3ee7c91 on itsjustdel:fixes/split-container-hidden-sizing into 638ae24 on fyne-io:master.

andydotxyz
andydotxyz requested changes Oct 21, 2022
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but it should be based on the develop branch for it to be merged in for next release.

@itsjustdel itsjustdel changed the base branch from master to develop October 21, 2022 17:07
@itsjustdel itsjustdel dismissed Bluebugs’s stale review October 21, 2022 17:07

The base branch was changed.

Jacalz
Jacalz approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Looks good to me :)

andydotxyz
andydotxyz approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@andydotxyz andydotxyz merged commit 1ab550a into fyne-io:develop Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

@Jacalz Jacalz Jacalz approved these changes

@Bluebugs Bluebugs Bluebugs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split Container does not respect item's Visible status
5 participants
@itsjustdel @coveralls @andydotxyz @Bluebugs @Jacalz